Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2154253002: [parser] Refactor some CHECK_OK calls (Closed)

Created:
4 years, 5 months ago by nickie
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Refactor some CHECK_OK calls R=adamk@chromium.org, littledan@chromium.org BUG= LOG=N Committed: https://crrev.com/ee48d322d73012989b35c5113f1ba0105aa7f0a9 Cr-Commit-Position: refs/heads/master@{#37851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -74 lines) Patch
M src/parsing/parser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 9 chunks +25 lines, -24 lines 0 comments Download
M src/parsing/parser-base.h View 8 chunks +40 lines, -37 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/preparser.cc View 6 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nickie
4 years, 5 months ago (2016-07-18 14:16:24 UTC) #1
adamk
Great cleanup, lgtm
4 years, 5 months ago (2016-07-18 17:03:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154253002/1
4 years, 5 months ago (2016-07-19 08:01:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 08:03:52 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 08:06:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee48d322d73012989b35c5113f1ba0105aa7f0a9
Cr-Commit-Position: refs/heads/master@{#37851}

Powered by Google App Engine
This is Rietveld 408576698