Rewrite YouTube Flash embeds

chrome/renderer/chrome_content_renderer_client_unittest.cc

Index: chrome/renderer/chrome_content_renderer_client_unittest.cc
diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc
index 898916fbe7657a8be1d6a079058986f32b62f16a..1fb060af1eac228cefa9be73786d081b73a53305 100644
--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc
+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc
@@ -408,3 +408,72 @@ TEST_F(ChromeContentRendererClientTest, ShouldSuppressErrorPage) {
   SearchBouncer::GetInstance()->OnSetSearchURLs(
       std::vector<GURL>(), GURL::EmptyGURL());
 }
+
+TEST_F(ChromeContentRendererClientTest, RewriteYouTubeFlashEmbedTest) {
+  ChromeContentRendererClient client;
+
+  std::string original = "";
+  std::string expected = "";
+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  original = "http://www.youtube.com";
+  expected = "http://www.youtube.com";

[mlamouri (slow - plz ping), 2016/07/20 13:22:02]

Maybe you should add a test without "www." and also one with some other bogus
subdomain like "foobar.youtube.com".

Also, could you add a test with "https://" ?

[kdsilva, 2016/07/21 13:59:46]

Done.

+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // Non-YouTube domains shouldn't be modified
+  original = "http://www.plus.google.com";
+  expected = "http://www.plus.google.com";
+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL isn't using Flash
+  original = "http://www.youtube.com/embed/cW44BpXpjYw";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw";
+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL isn't using Flash, has JS API enabled

[mlamouri (slow - plz ping), 2016/07/20 13:22:02]

You don't test enablejsapi=1 when /v/ is used.

[kdsilva, 2016/07/21 13:59:45]

Done.

+  original = "http://www.youtube.com/embed/cW44BpXpjYw?enablejsapi=1";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw?enablejsapi=1";
+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL isn't using Flash, is invalid
+  original = "http://www.youtube.com/embed/cW44BpXpjYw&start=4";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw&start=4";
+  EXPECT_FALSE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL is using Flash, is valid
+  original = "https://www.youtube.com/v/cW44BpXpjYw";
+  expected = "https://www.youtube.com/embed/cW44BpXpjYw";
+  EXPECT_TRUE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL is using Flash, is valid, has one parameter
+  original = "http://www.youtube.com/v/cW44BpXpjYw?start=4";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw?start=4";
+  EXPECT_TRUE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL is using Flash, is valid, has multiple parameters
+  original = "http://www.youtube.com/v/cW44BpXpjYw?start=4&fs=1";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw?start=4&fs=1";
+  EXPECT_TRUE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL is using Flash, is invalid, has one parameter
+  original = "http://www.youtube.com/v/cW44BpXpjYw&start=4";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw?start=4";
+  EXPECT_TRUE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);
+
+  // URL is using Flash, is invalid, has multiple parameters

[mlamouri (slow - plz ping), 2016/07/20 13:22:02]

Can you add one like this with
&foo=a&bar=b?tulip=c

[kdsilva, 2016/07/21 13:59:46]

Done.

+  original = "http://www.youtube.com/v/cW44BpXpjYw&start=4&fs=1";
+  expected = "http://www.youtube.com/embed/cW44BpXpjYw?start=4&fs=1";
+  EXPECT_TRUE(client.OverrideEmbedInfo(&original));
+  EXPECT_EQ(original, expected);

[mlamouri (slow - plz ping), 2016/07/20 13:22:02]

The tests look fine. I think it might be interesting to have all the
input/output in a big data structure and run a loop to test instead of
copy/pasting. Feel free to ignore this for now though.

[kdsilva, 2016/07/21 13:59:45]

Acknowledged.

+}
+