chrome/test/data/flash_embeds.html - Issue 2154233003: Rewrite YouTube Flash embeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/flash_embeds.html

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/flash_embeds.html

diff --git a/chrome/test/data/flash_embeds.html b/chrome/test/data/flash_embeds.html

new file mode 100644

index 0000000000000000000000000000000000000000..c617420d3f425cb1af2ce8c9b1802801248a2b17

--- /dev/null

+++ b/chrome/test/data/flash_embeds.html

@@ -0,0 +1,15 @@

+<!DOCTYPE html>

+<html>

+ <head></head>

+ <body>

+ <script>

+ function appendToDOM(url) {

+ var object = document.createElement("object");

+ var embed = document.createElement("embed");

+ embed.src = url;

+ object.appendChild(embed);

+ document.getElementsByTagName('body')[0].appendChild(object);

mlamouri (slow - plz ping) 2016/07/30 17:46:06 `document.body` is shorter than `document.getEleme

kdsilva 2016/08/01 12:42:44 Done.

+ }

+ </script>

+ </body>

mlamouri (slow - plz ping) 2016/07/30 17:46:06 Can you close the body before opening the script?

kdsilva 2016/08/01 12:42:45 Done.

+</html>