third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2154233003: Rewrite YouTube Flash embeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 1142b5e05cfd96908506836fa9e8a359be78e0c5..4e9dc1f45c99e3a8174d6c4eafd0bce30ac38505 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -1037,4 +1037,12 @@ WebEffectiveConnectionType FrameLoaderClientImpl::getEffectiveConnectionType()

return WebEffectiveConnectionType::TypeUnknown;

}

+String FrameLoaderClientImpl::OverrideFlashEmbedWithHTML(const String& url)

+ if (!m_webFrame->client()) {

+ return "";

+ }

mlamouri (slow - plz ping) 2016/07/28 19:46:54 style: no { }

kdsilva 2016/07/29 17:59:06 Done.

+ return m_webFrame->client()->overrideFlashEmbedWithHTML(WebString(url));

} // namespace blink