third_party/WebKit/public/web/WebFrameClient.h - Issue 2154233003: Rewrite YouTube Flash embeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebFrameClient.h

diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h

index 6f2e7bbeeef6d1bc0e5bffe023a632d9eb54eb00..430efb43b3c3fb49fee686a44f4179f1c70f5ffd 100644

--- a/third_party/WebKit/public/web/WebFrameClient.h

+++ b/third_party/WebKit/public/web/WebFrameClient.h

@@ -727,6 +727,12 @@ public:

return WebPageVisibilityStateVisible;

}

+ // Overwrites the given URL to use an HTML5 video player if possible.

+ virtual WebString overrideFlashEmbedWithHTML(const WebString& url)

+ {

+ return url;

mlamouri (slow - plz ping) 2016/07/21 15:55:08 Shouldn't it be the empty string?

kdsilva 2016/07/22 13:55:58 Done.

+ }

protected:

virtual ~WebFrameClient() { }

};