Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Side by Side Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_content_renderer_client.h" 5 #include "chrome/renderer/chrome_content_renderer_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/debug/crash_logging.h" 11 #include "base/debug/crash_logging.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/metrics/field_trial.h" 14 #include "base/metrics/field_trial.h"
15 #include "base/metrics/histogram.h" 15 #include "base/metrics/histogram.h"
16 #include "base/metrics/user_metrics_action.h" 16 #include "base/metrics/user_metrics_action.h"
17 #include "base/strings/string_number_conversions.h" 17 #include "base/strings/string_number_conversions.h"
18 #include "base/strings/string_util.h" 18 #include "base/strings/string_util.h"
19 #include "base/strings/utf_string_conversions.h" 19 #include "base/strings/utf_string_conversions.h"
20 #include "base/time/time.h" 20 #include "base/time/time.h"
21 #include "base/values.h" 21 #include "base/values.h"
22 #include "build/build_config.h" 22 #include "build/build_config.h"
23 #include "chrome/common/channel_info.h" 23 #include "chrome/common/channel_info.h"
24 #include "chrome/common/chrome_features.h"
24 #include "chrome/common/chrome_isolated_world_ids.h" 25 #include "chrome/common/chrome_isolated_world_ids.h"
25 #include "chrome/common/chrome_paths.h" 26 #include "chrome/common/chrome_paths.h"
26 #include "chrome/common/chrome_switches.h" 27 #include "chrome/common/chrome_switches.h"
27 #include "chrome/common/crash_keys.h" 28 #include "chrome/common/crash_keys.h"
28 #include "chrome/common/pepper_permission_util.h" 29 #include "chrome/common/pepper_permission_util.h"
29 #include "chrome/common/render_messages.h" 30 #include "chrome/common/render_messages.h"
30 #include "chrome/common/secure_origin_whitelist.h" 31 #include "chrome/common/secure_origin_whitelist.h"
31 #include "chrome/common/url_constants.h" 32 #include "chrome/common/url_constants.h"
32 #include "chrome/grit/generated_resources.h" 33 #include "chrome/grit/generated_resources.h"
33 #include "chrome/grit/locale_settings.h" 34 #include "chrome/grit/locale_settings.h"
(...skipping 1338 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 // chrome.system.network.getNetworkInterfaces provides the same 1373 // chrome.system.network.getNetworkInterfaces provides the same
1373 // information. Also, the enforcement of sending and binding UDP is already done 1374 // information. Also, the enforcement of sending and binding UDP is already done
1374 // by chrome extension permission model. 1375 // by chrome extension permission model.
1375 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() { 1376 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
1376 #if defined(ENABLE_EXTENSIONS) 1377 #if defined(ENABLE_EXTENSIONS)
1377 return !IsStandaloneExtensionProcess(); 1378 return !IsStandaloneExtensionProcess();
1378 #else 1379 #else
1379 return true; 1380 return true;
1380 #endif 1381 #endif
1381 } 1382 }
1383
1384 GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) {
1385 if (!base::FeatureList::IsEnabled(features::kOverrideYouTubeFlashEmbed))
1386 return GURL();
1387
1388 if (!url.is_valid())
1389 return GURL();
1390
1391 // We'll only modify YouTube Flash embeds. The URLs can be recognized since
1392 // they're in the following form: youtube.com/v/VIDEO_ID. So, we check to see
1393 // if the given URL does follow that format.
1394 if (!url.DomainIs("youtube.com") || url.path().find("/v/") != 0)
1395 return GURL();
1396
1397 std::string url_str = url.spec();
1398
1399 // If the website is using an invalid YouTube URL, we'll try and
1400 // fix the URL by ensuring that if there are multiple parameters,
1401 // the parameter string begins with a "?" and then follows with a "&"
1402 // for each subsequent parameter. We do this becuase the Flash vide player
Avi (use Gerrit) 2016/08/02 15:59:38 typo: because typo: video
kdsilva 2016/08/02 16:55:36 Wow, what an embarrassing mistake. Thanks for the
1403 // has some URL correction capabilities so we don't want this move to HTML5
1404 // to break webpages that used to work.
1405 size_t index = url_str.find_first_of("&?");
1406 bool invalid_url = index != std::string::npos && url_str.at(index) == '&';
1407
1408 if (invalid_url) {
1409 // ? should appear first before all parameters
1410 url_str.replace(index, 1, "?");
1411
1412 // Replace all instances of ? (after the first) with &
1413 for (size_t pos = index + 1;
1414 (pos = url_str.find("?",pos )) != std::string::npos; pos += 1)
1415 url_str.replace(pos, 1, "&");
1416 }
1417
1418 GURL corrected_url = GURL(url_str);
1419
1420 // We don't modify any URLs that contain the enablejsapi=1 parameter
1421 // since the page may be interacting with the YouTube Flash player in
1422 // Javascript and we don't want to break working content.
1423 if (corrected_url.query().find("enablejsapi=1") != std::string::npos)
1424 return GURL();
1425
1426 // Change the path to use the YouTube HTML5 API
1427 std::string path = corrected_url.path();
1428 path.replace(path.find("/v/"), 3, "/embed/");
1429
1430 url::Replacements<char> r;
1431 r.SetPath(path.c_str(), url::Component(0, path.length()));
1432
1433 return corrected_url.ReplaceComponents(r);
1434 }
OLDNEW
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_content_renderer_client_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698