third_party/WebKit/Source/core/DEPS - Issue 2154233003: Rewrite YouTube Flash embeds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/DEPS

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+bindings/core",	2 "+bindings/core",

3 "-bindings/modules",	3 "-bindings/modules",

4 "+core",	4 "+core",

5 "-inspector/v8",	5 "-inspector/v8",

6 "+inspector/v8/public",	6 "+inspector/v8/public",

	7 "+media/base",
	mlamouri (slow - plz ping) 2016/07/28 13:05:13 I don't think you need that, do you? I don't think you need that, do you? kdsilva 2016/07/28 15:17:18 Looks like I don't! Not sure why I thought I did.. Show quoted text On 2016/07/28 13:05:13, Mounir Lamouri wrote: > I don't think you need that, do you? Looks like I don't! Not sure why I thought I did... mlamouri (slow - plz ping) 2016/07/28 19:46:54 Maybe you added the feature flag to the media list Show quoted text On 2016/07/28 at 15:17:18, kdsilva wrote: > On 2016/07/28 13:05:13, Mounir Lamouri wrote: > > I don't think you need that, do you? > > Looks like I don't! Not sure why I thought I did... Maybe you added the feature flag to the media list first?
7 "-modules",	8 "-modules",

8 "+platform",	9 "+platform",

9 "+public/platform",	10 "+public/platform",

10 "-public/web",	11 "-public/web",

11 "+third_party/skia/include",	12 "+third_party/skia/include",

12 "-web",	13 "-web",

13 ]	14 ]

OLD	NEW