chrome/renderer/DEPS - Issue 2154233003: Rewrite YouTube Flash embeds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/DEPS

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+chrome/browser/ui",

	3 "+chrome/browser/ui/tabs",
	mlamouri (slow - plz ping) 2016/07/28 13:05:12 You should have "specific_include_rules" so the ex You should have "specific_include_rules" so the expception only applies to the test, see: https://cs.chromium.org/chromium/src/chrome/renderer/safe_browsing/DEPS?q=f:c... kdsilva 2016/07/28 15:17:16 Done. Show quoted text On 2016/07/28 13:05:12, Mounir Lamouri wrote: > You should have "specific_include_rules" so the expception only applies to the > test, see: > https://cs.chromium.org/chromium/src/chrome/renderer/safe_browsing/DEPS?q=f:c... Done.
2 "+chrome/grit", # For generated headers	4 "+chrome/grit", # For generated headers

3 "+components/autofill/content/common",	5 "+components/autofill/content/common",

4 "+components/autofill/content/renderer",	6 "+components/autofill/content/renderer",

5 "+components/autofill/core/common",	7 "+components/autofill/core/common",

6 "+components/cdm/renderer",	8 "+components/cdm/renderer",

7 "+components/content_settings/content/common",	9 "+components/content_settings/content/common",

8 "+components/content_settings/core/common",	10 "+components/content_settings/core/common",

9 "+components/contextual_search/renderer",	11 "+components/contextual_search/renderer",

10 "+components/crx_file",	12 "+components/crx_file",

11 "+components/data_reduction_proxy/content/common",	13 "+components/data_reduction_proxy/content/common",

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 "+extensions/renderer",	45 "+extensions/renderer",

44 "+gin",	46 "+gin",

45 "+grit", # For generated headers. TODO(thestig): Remove.	47 "+grit", # For generated headers. TODO(thestig): Remove.

46 "+media/base",	48 "+media/base",

47 "+ppapi/c",	49 "+ppapi/c",

48 "+ppapi/shared_impl",	50 "+ppapi/shared_impl",

49 "+services/shell/public/cpp",	51 "+services/shell/public/cpp",

50 "+skia",	52 "+skia",

51 "+storage/common",	53 "+storage/common",

52 ]	54 ]

OLD	NEW