content/public/renderer/content_renderer_client.cc - Issue 2154233003: Rewrite YouTube Flash embeds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/renderer/content_renderer_client.cc

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/chrome_content_renderer_client_unittest.cc ('K') | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_frame_impl.h » ('j') | content/renderer/render_frame_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/renderer/content_renderer_client.h"	5 #include "content/public/renderer/content_renderer_client.h"

6	6

7 #include "content/public/renderer/media_stream_renderer_factory.h"	7 #include "content/public/renderer/media_stream_renderer_factory.h"

8 #include "media/base/renderer_factory.h"	8 #include "media/base/renderer_factory.h"

9 #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerClie nt.h"	9 #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerClie nt.h"

10	10

(...skipping 210 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
221	221

222 std::unique_ptr<blink::WebAppBannerClient>	222 std::unique_ptr<blink::WebAppBannerClient>

223 ContentRendererClient::CreateAppBannerClient(RenderFrame* render_frame) {	223 ContentRendererClient::CreateAppBannerClient(RenderFrame* render_frame) {

224 return nullptr;	224 return nullptr;

225 }	225 }

226	226

227 bool ContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {	227 bool ContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {

228 return true;	228 return true;

229 }	229 }

230	230

	231 std::string ContentRendererClient::OverrideFlashEmbedWithHTML(

	232 const std::string& url) {

	233 return url;
	mlamouri (slow - plz ping) 2016/07/21 15:55:07 Shouldn't it be the empty string? Shouldn't it be the empty string? kdsilva 2016/07/22 13:55:58 Done. Show quoted text On 2016/07/21 15:55:07, Mounir Lamouri wrote: > Shouldn't it be the empty string? Done.
	234 }

	235

231 } // namespace content	236 } // namespace content

OLD	NEW