Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 215423004: [telemetry] Minor Cloud Storage script fixes. (Closed)

Created:
6 years, 9 months ago by dtu
Modified:
6 years, 8 months ago
Reviewers:
cmp, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Minor Cloud Storage script fixes. - Fix error where you couldn't list buckets if you didn't have access to all of them. - Fix bug where listing with shell completion (page_sets/*) would only give the first file. - Skip moving files if the destination bucket is the same as the source bucket. - Remove checks that all files exist. If you use shell completion, you will include files that don't have hash files, just ignore them. BUG=None. TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M tools/telemetry/cloud_storage View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dtu
6 years, 9 months ago (2014-03-27 21:41:29 UTC) #1
tonyg
lgtm
6 years, 9 months ago (2014-03-27 22:25:37 UTC) #2
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 9 months ago (2014-03-27 22:29:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/215423004/1
6 years, 9 months ago (2014-03-27 22:29:35 UTC) #4
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:28:13 UTC) #5
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:31:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/215423004/1
6 years, 8 months ago (2014-03-30 16:32:10 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:01:40 UTC) #8
Message was sent while issue was closed.
Change committed as 260435

Powered by Google App Engine
This is Rietveld 408576698