Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: chrome/browser/resources/options/preferences.js

Issue 215423002: [Hotword] Make ConfirmDialog subclass from SettingsDialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/preferences.js
diff --git a/chrome/browser/resources/options/preferences.js b/chrome/browser/resources/options/preferences.js
index 6f8cc8294176437ecb8a82f8dbcb37db9086fac6..ef1ed18cf903a61d12cb2a0eb772d3b07949f257 100644
--- a/chrome/browser/resources/options/preferences.js
+++ b/chrome/browser/resources/options/preferences.js
@@ -214,12 +214,11 @@ cr.define('options', function() {
var event = new Event(name);
// Decorate pref value as CoreOptionsHandler::CreateValueForPref() does.
- event.value = {
- value: value,
- recommendedValue: pref.orig.recommendedValue,
- disabled: pref.orig.disabled,
- uncommitted: true,
- };
+ event.value = {value: value, uncommitted: true};
+ if (pref.orig) {
+ event.value.recommendedValue = pref.orig.recommendedValue;
+ event.value.disabled = pref.orig.disabled;
+ }
this.dispatchEvent(event);
},
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698