[Hotword] Make ConfirmDialog subclass from SettingsDialog

chrome/browser/resources/options/preferences.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   /////////////////////////////////////////////////////////////////////////////
   // Preferences class:
 
   /**
@@ skipping 198 matching lines @@
     setPrefNoCommit_: function(name, type, value) {
       var pref = this.registeredPreferences_[name];
       pref.action = 'set';
       pref.type = type;
       pref.value = value;
 
       var event = new Event(name);
       // Decorate pref value as CoreOptionsHandler::CreateValueForPref() does.
       event.value = {
         value: value,
-        recommendedValue: pref.orig.recommendedValue,
-        disabled: pref.orig.disabled,
+        recommendedValue: pref.orig ? pref.orig.recommendedValue : undefined,
+        disabled: pref.orig ? pref.orig.disabled : undefined,
         uncommitted: true,
       };

[Dan Beam, 2014/03/27 21:06:43]

nit:

event.value = {value: value, uncommitted: true};
if (pref.orig) {
  event.value.recommendedValue = pref.orig.recommendedValue;
  event.value.disabled = pref.orig.disabled;
}

[rpetterson, 2014/03/27 21:26:00]

Done.

       this.dispatchEvent(event);
     },
 
     /**
      * Clears a preference and signals its new value. The change is propagated
      * throughout the UI code but is not committed to Chrome yet.
      * @param {string} name Preference name.
      * @private
      */
     clearPrefNoCommit_: function(name) {
@@ skipping 96 matching lines @@
     prefs.registeredPreferences_[notification[0]] = {orig: notification[1]};
     prefs.dispatchEvent(event);
   };
 
   // Export
   return {
     Preferences: Preferences
   };
 
 });