Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215423002: [Hotword] Make ConfirmDialog subclass from SettingsDialog (Closed)

Created:
6 years, 8 months ago by rpetterson
Modified:
6 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, James Hawkins
Visibility:
Public.

Description

[Hotword] Make ConfirmDialog subclass from SettingsDialog so that any preferences set in the ConfirmDialog will update. BUG=345811 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260196

Patch Set 1 #

Patch Set 2 : some more cleanup #

Total comments: 10

Patch Set 3 : move calls, fix nit #

Patch Set 4 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M chrome/browser/resources/options/confirm_dialog.js View 1 2 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/hotword_confirm_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/preferences.js View 1 2 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
rpetterson
Hi, Dan, James actually did the heavy lifting in the CL. I tested to make ...
6 years, 8 months ago (2014-03-27 20:42:43 UTC) #1
Dan Beam
https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/confirm_dialog.js File chrome/browser/resources/options/confirm_dialog.js (right): https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/confirm_dialog.js#newcode92 chrome/browser/resources/options/confirm_dialog.js:92: SettingsDialog.prototype.handleConfirm.call(this); ^ why is this at the bottom? https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/confirm_dialog.js#newcode102 ...
6 years, 8 months ago (2014-03-27 21:06:43 UTC) #2
rpetterson
https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/confirm_dialog.js File chrome/browser/resources/options/confirm_dialog.js (right): https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/confirm_dialog.js#newcode92 chrome/browser/resources/options/confirm_dialog.js:92: SettingsDialog.prototype.handleConfirm.call(this); On 2014/03/27 21:06:43, Dan Beam wrote: > ^ ...
6 years, 8 months ago (2014-03-27 21:25:59 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/pref_ui.js File chrome/browser/resources/options/pref_ui.js (right): https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/pref_ui.js#newcode164 chrome/browser/resources/options/pref_ui.js:164: // Prime the checkbox pref, as it may ...
6 years, 8 months ago (2014-03-28 00:00:41 UTC) #4
rpetterson
Thanks! https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/pref_ui.js File chrome/browser/resources/options/pref_ui.js (right): https://codereview.chromium.org/215423002/diff/20001/chrome/browser/resources/options/pref_ui.js#newcode164 chrome/browser/resources/options/pref_ui.js:164: // Prime the checkbox pref, as it may ...
6 years, 8 months ago (2014-03-28 00:05:35 UTC) #5
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 8 months ago (2014-03-28 03:35:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/215423002/60001
6 years, 8 months ago (2014-03-28 03:37:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 05:41:43 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136755
6 years, 8 months ago (2014-03-28 05:41:43 UTC) #9
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 8 months ago (2014-03-28 06:09:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/215423002/60001
6 years, 8 months ago (2014-03-28 06:10:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 10:31:06 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137057
6 years, 8 months ago (2014-03-28 10:31:06 UTC) #13
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 8 months ago (2014-03-28 15:32:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/215423002/60001
6 years, 8 months ago (2014-03-28 15:33:29 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 18:09:29 UTC) #16
Message was sent while issue was closed. 
Change committed as 260196

Powered by Google App Engine
This is Rietveld 408576698