scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json - Issue 2154223003: Revert of [Skia] Convert Sk Images to a CIPD package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json

Issue 2154223003: Revert of [Skia] Convert Sk Images to a CIPD package (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_test.expected/missing_SKP_VERSION_device.json ('k') | scripts/slave/recipes/skia/swarm_trigger.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json

diff --git a/scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json b/scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json

index ad9df1ef5fa5068e6eb498957b90ffed7b87e9d8..402185eb2c3208e8759895f8f9f7aa822e853940 100644

--- a/scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json

+++ b/scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json

@@ -299,20 +299,10 @@

"python",

"-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/skia/infra/bots/assets/skimage/VERSION",

+ "[SLAVE_BUILD]/tmp/SK_IMAGE_VERSION",

"/path/to/tmp/"

- "name": "Get downloaded skimage VERSION"

- },

- {

- "cmd": [

- "python",

- "-u",

- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "42",

- "[SLAVE_BUILD]/tmp/SK_IMAGE_VERSION"

- ],

- "name": "write SK_IMAGE_VERSION"

+ "name": "Get downloaded SK_IMAGE_VERSION"

{

"cmd": [

@@ -414,7 +404,7 @@

"cmd": [

"[SLAVE_BUILD]/skia/platform_tools/android/bin/adb_push_if_needed",

"--verbose",

- "[SLAVE_BUILD]/skimage",

+ "[SLAVE_BUILD]/images",

"/storage/emulated/legacy/skiabot/skia_images"

"env": {

@@ -427,7 +417,7 @@

"SKIA_ANDROID_VERBOSE_SETUP": "1",

"SKIA_OUT": "[SLAVE_BUILD]/out"

- "name": "push skimage"

+ "name": "push images"

{

"cmd": [