Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2154213008: Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0211-settings-router-impl-part-3-navigateTo
Patch Set: change test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/device_page/device_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * 'settings-appearance-page' is the settings page containing appearance 6 * 'settings-appearance-page' is the settings page containing appearance
7 * settings. 7 * settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 }, 183 },
184 </if> 184 </if>
185 185
186 /** @private */ 186 /** @private */
187 resetTheme_: function() { 187 resetTheme_: function() {
188 this.browserProxy_.resetTheme(); 188 this.browserProxy_.resetTheme();
189 }, 189 },
190 190
191 /** @private */ 191 /** @private */
192 showFontsPage_: function() { 192 showFontsPage_: function() {
193 return this.currentRoute.subpage[0] == 'appearance-fonts'; 193 return this.currentRoute == settings.Route.FONTS;
194 }, 194 },
195 195
196 /** 196 /**
197 * @param {string} themeId The theme ID. 197 * @param {string} themeId The theme ID.
198 * @private 198 * @private
199 */ 199 */
200 themeChanged_: function(themeId) { 200 themeChanged_: function(themeId) {
201 if (themeId) { 201 if (themeId) {
202 chrome.management.get(themeId, 202 chrome.management.get(themeId,
203 function(info) { 203 function(info) {
(...skipping 25 matching lines...) Expand all
229 229
230 /** 230 /**
231 * @param {boolean} bookmarksBarVisible if bookmarks bar option is visible. 231 * @param {boolean} bookmarksBarVisible if bookmarks bar option is visible.
232 * @return {string} 'first' if the argument is false or empty otherwise. 232 * @return {string} 'first' if the argument is false or empty otherwise.
233 * @private 233 * @private
234 */ 234 */
235 getFirst_: function(bookmarksBarVisible) { 235 getFirst_: function(bookmarksBarVisible) {
236 return !bookmarksBarVisible ? 'first' : ''; 236 return !bookmarksBarVisible ? 'first' : '';
237 } 237 }
238 }); 238 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/device_page/device_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698