Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2154213004: Revert of tryserver.chromium.win: convert chromium_trybot builders to remote_run (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of tryserver.chromium.win: convert chromium_trybot builders to remote_run (patchset #2 id:20001 of https://codereview.chromium.org/2156443003/ ) Reason for revert: speculative revert: I think this CL is what caused the bootstrapping failures, indirectly. See https://bugs.chromium.org/p/chromium/issues/detail?id=629025#c25 BUG=629025 Original issue's description: > tryserver.chromium.win: convert chromium_trybot builders to remote_run > > BUG=584079, 593999 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/aeba783f0b7913549b0cadaedd4e058fa5df812b TBR=emso@chromium.org,sergiyb@chromium.org,phajdan.jr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584079, 593999

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -648 lines) Patch
M masters/master.tryserver.chromium.win/master.cfg View 3 chunks +38 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium.py View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 5 chunks +0 lines, -5 lines 1 comment Download
M scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_win.py View 6 chunks +0 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_Win.json View 8 chunks +11 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json View 7 chunks +9 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 10 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 14 chunks +19 lines, -19 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 14 chunks +19 lines, -19 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 14 chunks +19 lines, -19 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 14 chunks +19 lines, -19 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win_SyzyAsan__rel_.json View 7 chunks +9 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_x64_GN.json View 9 chunks +12 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json View 16 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json View 16 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_WinClang64__dbg_.json View 12 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_dbg.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_rel.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chrome_official.json View 12 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_dbg_ng.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_dbg_ng.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json View 14 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_syzyasan_rel.json View 9 chunks +11 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg.json View 12 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel.json View 12 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg.json View 12 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel.json View 12 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json View 14 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json View 20 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 20 chunks +28 lines, -28 lines 0 comments Download
M tests/masters_recipes_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tandrii(chromium)
Created Revert of tryserver.chromium.win: convert chromium_trybot builders to remote_run
4 years, 5 months ago (2016-07-18 22:44:46 UTC) #1
martiniss
https://codereview.chromium.org/2154213004/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (left): https://codereview.chromium.org/2154213004/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#oldcode2146 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2146: 'checkout_dir': 'win', This (and other lines like it, I ...
4 years, 5 months ago (2016-07-18 22:55:13 UTC) #7
martiniss
lgtm
4 years, 5 months ago (2016-07-18 23:26:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154213004/1
4 years, 5 months ago (2016-07-18 23:27:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6267)
4 years, 5 months ago (2016-07-18 23:37:18 UTC) #12
emso
4 years, 5 months ago (2016-07-20 08:40:56 UTC) #13 
lgtm

Powered by Google App Engine
This is Rietveld 408576698