third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp - Issue 2154213003: Prevent 'javascript:' URL execution in sandboxed frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

Issue 2154213003: Prevent 'javascript:' URL execution in sandboxed frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

index 5ad6f3a364b649147e4f84259d33fdde23f3c3fd..2ee42f3d64356790b065e25232b833ba4e7ad9f8 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

@@ -93,6 +93,8 @@ void HTMLFrameElementBase::openURL(bool replaceCurrentItem)

return;

if (!contentFrame() || scriptURL.isEmpty() || !contentFrame()->isLocalFrame())

return;

+ if (contentFrame()->owner()->getSandboxFlags() & SandboxOrigin)

+ return;

toLocalFrame(contentFrame())->script().executeScriptIfJavaScriptURL(scriptURL);

}

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/sandboxed-iframe-javascript-url.html ('k') | no next file » | no next file with comments »