Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2154203004: [Media Router WebUI] Update "Device missing?" messaging. (Closed)

Created:
4 years, 5 months ago by apacible
Modified:
4 years, 5 months ago
Reviewers:
Stephen, imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org, jonnymack, Stephen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update "Device missing?" messaging. BUG=629135 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8dc61ccc8270008d0c3eb004b06be34ecd2f88ca Cr-Commit-Position: refs/heads/master@{#406184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/media_router_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
apacible
PTAL, thanks! +skonig, jonnymack as this change was initiated via feedback https://screenshot.googleplex.com/ctC6RHxxLaQ.png I kept the ...
4 years, 5 months ago (2016-07-18 18:04:42 UTC) #6
Stephen
lgtm, thanks!
4 years, 5 months ago (2016-07-18 18:07:27 UTC) #8
imcheng
lgtm
4 years, 5 months ago (2016-07-18 18:59:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154203004/1
4 years, 5 months ago (2016-07-18 22:12:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 02:05:09 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 02:05:16 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 02:08:12 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dc61ccc8270008d0c3eb004b06be34ecd2f88ca
Cr-Commit-Position: refs/heads/master@{#406184}

Powered by Google App Engine
This is Rietveld 408576698