Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 21542003: Android: Speech Recognition depends on ExperimentalWebPlatformFeatures (Closed)

Created:
7 years, 4 months ago by janx
Modified:
7 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: Speech Recognition depends on ExperimentalWebPlatformFeatures Web Speech Recognition is an experimental web platform feature on Android and should be guarded behind the corresponding flag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/child/runtime_features.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
janx
Avi, could you please have a look? I'm adding an additional safeguard to my feature ...
7 years, 4 months ago (2013-08-01 17:34:42 UTC) #1
Avi (use Gerrit)
Moar paranoia! LGTM
7 years, 4 months ago (2013-08-01 17:44:45 UTC) #2
janx
Thanks Avi!
7 years, 4 months ago (2013-08-01 18:26:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/21542003/1
7 years, 4 months ago (2013-08-01 18:28:59 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 21:22:33 UTC) #5
Message was sent while issue was closed.
Change committed as 215109

Powered by Google App Engine
This is Rietveld 408576698