Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 21542002: Make CharacterData::insertData() / deleteData() / replaceData() arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline fast/dom/characterdata-appendData-argument.html Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
index e97322937015dd40b209f5c3d07561397a7b400b..5e9cc8afcafc34364717c87e1b33239d7ae837c8 100644
--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
@@ -189,7 +189,7 @@ shouldBe("nonNumericPolicy('document.createTextNode(\"a\").substringData(x, 0)')
shouldBe("nonNumericPolicy('document.createTextNode(\"a\").substringData(0, x)')", "'any type allowed'");
shouldBe("nonNumericPolicy('document.createTextNode(\"a\").insertData(x, \"b\")')", "'any type allowed'");
shouldBe("nonNumericPolicy('document.createTextNode(\"a\").deleteData(x, 0)')", "'any type allowed'");
-shouldBe("nonNumericPolicy('document.createTextNode(\"a\").deleteData(0, x)')", "'any type allowed'");
+shouldBe("nonNumericPolicy('document.createTextNode(\"a\").deleteData(0, x)')", "'any type allowed (but not omitted)'");
shouldBe("nonNumericPolicy('document.createTextNode(\"a\").replaceData(x, 0, \"b\")')", "'any type allowed'");
shouldBe("nonNumericPolicy('document.createTextNode(\"a\").replaceData(0, x, \"b\")')", "'any type allowed'");
« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | Source/core/dom/CharacterData.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698