Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issue 2154193003: Delete the legacy SVG parser (Closed)

Created:
4 years, 5 months ago by f(malita)
Modified:
4 years, 5 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete the legacy SVG parser Unused. R=reed@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154193003 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/01c97230f890ca2650e490234a4c5e5190049fdc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2941 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M gyp/svg.gyp View 1 chunk +0 lines, -80 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/svg/parser/SkSVGAttribute.h View 1 chunk +0 lines, -43 lines 0 comments Download
D include/svg/parser/SkSVGBase.h View 1 chunk +0 lines, -25 lines 0 comments Download
D include/svg/parser/SkSVGPaintState.h View 1 chunk +0 lines, -89 lines 0 comments Download
D include/svg/parser/SkSVGParser.h View 1 chunk +0 lines, -73 lines 0 comments Download
D include/svg/parser/SkSVGTypes.h View 1 chunk +0 lines, -40 lines 0 comments Download
D src/svg/parser/SkSVG.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D src/svg/parser/SkSVGCircle.h View 1 chunk +0 lines, -23 lines 0 comments Download
D src/svg/parser/SkSVGCircle.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D src/svg/parser/SkSVGClipPath.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/svg/parser/SkSVGClipPath.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D src/svg/parser/SkSVGDefs.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/svg/parser/SkSVGDefs.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D src/svg/parser/SkSVGElements.h View 1 chunk +0 lines, -72 lines 0 comments Download
D src/svg/parser/SkSVGElements.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
D src/svg/parser/SkSVGEllipse.h View 1 chunk +0 lines, -24 lines 0 comments Download
D src/svg/parser/SkSVGEllipse.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D src/svg/parser/SkSVGFeColorMatrix.h View 1 chunk +0 lines, -25 lines 0 comments Download
D src/svg/parser/SkSVGFeColorMatrix.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D src/svg/parser/SkSVGFilter.h View 1 chunk +0 lines, -26 lines 0 comments Download
D src/svg/parser/SkSVGFilter.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D src/svg/parser/SkSVGG.h View 1 chunk +0 lines, -20 lines 0 comments Download
D src/svg/parser/SkSVGG.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D src/svg/parser/SkSVGGradient.h View 1 chunk +0 lines, -28 lines 0 comments Download
D src/svg/parser/SkSVGGradient.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
D src/svg/parser/SkSVGGroup.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/svg/parser/SkSVGGroup.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D src/svg/parser/SkSVGImage.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/svg/parser/SkSVGImage.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D src/svg/parser/SkSVGLine.h View 1 chunk +0 lines, -24 lines 0 comments Download
D src/svg/parser/SkSVGLine.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D src/svg/parser/SkSVGLinearGradient.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/svg/parser/SkSVGLinearGradient.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D src/svg/parser/SkSVGMask.h View 1 chunk +0 lines, -28 lines 0 comments Download
D src/svg/parser/SkSVGMask.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D src/svg/parser/SkSVGMetadata.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/svg/parser/SkSVGMetadata.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D src/svg/parser/SkSVGPaintState.cpp View 1 chunk +0 lines, -453 lines 0 comments Download
D src/svg/parser/SkSVGParser.cpp View 1 chunk +0 lines, -440 lines 0 comments Download
D src/svg/parser/SkSVGPath.h View 1 chunk +0 lines, -21 lines 0 comments Download
D src/svg/parser/SkSVGPath.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D src/svg/parser/SkSVGPolygon.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/svg/parser/SkSVGPolygon.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D src/svg/parser/SkSVGPolyline.h View 1 chunk +0 lines, -26 lines 0 comments Download
D src/svg/parser/SkSVGPolyline.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D src/svg/parser/SkSVGRadialGradient.h View 1 chunk +0 lines, -29 lines 0 comments Download
D src/svg/parser/SkSVGRadialGradient.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D src/svg/parser/SkSVGRect.h View 1 chunk +0 lines, -25 lines 0 comments Download
D src/svg/parser/SkSVGRect.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
D src/svg/parser/SkSVGSVG.h View 1 chunk +0 lines, -33 lines 0 comments Download
D src/svg/parser/SkSVGSVG.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
D src/svg/parser/SkSVGStop.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/svg/parser/SkSVGStop.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D src/svg/parser/SkSVGSymbol.h View 1 chunk +0 lines, -21 lines 0 comments Download
D src/svg/parser/SkSVGSymbol.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D src/svg/parser/SkSVGText.h View 1 chunk +0 lines, -31 lines 0 comments Download
D src/svg/parser/SkSVGText.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
D src/svg/parser/SkSVGUse.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/svg/parser/SkSVGUse.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
f(malita)
4 years, 5 months ago (2016-07-18 21:45:28 UTC) #2
robertphillips
lgtm
4 years, 5 months ago (2016-07-18 21:54:51 UTC) #6
reed1
lgtm
4 years, 5 months ago (2016-07-19 10:28:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154193003/1
4 years, 5 months ago (2016-07-19 13:11:51 UTC) #12
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 5 months ago (2016-07-19 13:11:53 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:12:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/01c97230f890ca2650e490234a4c5e5190049fdc

Powered by Google App Engine
This is Rietveld 408576698