Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: ios/chrome/browser/ui/context_menu/context_menu_coordinator.h

Issue 2154163002: Change ContextMenu to use AlertCoordinator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertCoordinatorDelegate
Patch Set: Typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
diff --git a/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h b/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
index 7f1daf20e5afd82a7204b251b44d251bb8773779..fd7ef49fb994f676c87797cca46f34b92ea9414a 100644
--- a/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
+++ b/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
@@ -8,6 +8,7 @@
#import <UIKit/UIKit.h>
#include "base/ios/block_types.h"
+#import "ios/chrome/browser/chrome_coordinator.h"
namespace web {
struct ContextMenuParams;
@@ -15,7 +16,9 @@ struct ContextMenuParams;
// Abstracts displaying context menus for all device form factors. Will show a
// sheet on the phone and use a popover on a tablet.
-@interface ContextMenuCoordinator : NSObject
+// Once this coordinator is stopped, the underlying alert and any menu items
+// which have been added are deleted.
+@interface ContextMenuCoordinator : ChromeCoordinator
// Whether the context menu is visible. This will be true after |-start| is
// called until a subsequent |-stop|.
@@ -23,18 +26,21 @@ struct ContextMenuParams;
// Initializes with details provided in |params|. Context menu will be presented
// from |viewController|.
+- (instancetype)initWithBaseViewController:(UIViewController*)viewController
+ params:(const web::ContextMenuParams&)params
+ NS_DESIGNATED_INITIALIZER;
+
+// Used for downstream compatibility.
- (instancetype)initWithViewController:(UIViewController*)viewController
params:(const web::ContextMenuParams&)params;
+// Params are needed for the initialization.
+- (instancetype)initWithBaseViewController:(UIViewController*)viewController
+ NS_UNAVAILABLE;
+
// Adds an item at the end of the menu if |visible| is false.
- (void)addItemWithTitle:(NSString*)title action:(ProceduralBlock)action;
-// Displays the context menu.
-- (void)start;
-// Dismisses the context menu. Any menu items which have been added will be
-// cleared after this call.
-- (void)stop;
-
@end
#endif // IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_COORDINATOR_H_

Powered by Google App Engine
This is Rietveld 408576698