Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2154083002: Remove ConstantFinder constructor parameters. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ConstantFinder constructor parameters. ConstantFinder does not use any of these parameters. Also remove corresponding parameters in clients. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/056e0f16a6eb4c0f98d86c07d98ba5e16027d90f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/utilities.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 7 chunks +7 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 5 months ago (2016-07-17 00:15:48 UTC) #1
Brian Wilkerson
Have you checked to make sure that this change won't break any other clients? Part ...
4 years, 5 months ago (2016-07-18 13:51:22 UTC) #2
scheglov
On 2016/07/18 13:51:22, Brian Wilkerson wrote: > Have you checked to make sure that this ...
4 years, 5 months ago (2016-07-18 16:10:26 UTC) #3
Brian Wilkerson
I must have misread one of the paths; I thought one of the files was ...
4 years, 5 months ago (2016-07-18 16:50:13 UTC) #4
scheglov
4 years, 5 months ago (2016-07-18 17:30:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
056e0f16a6eb4c0f98d86c07d98ba5e16027d90f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698