Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: src/compiler/representation-change.cc

Issue 2154073002: [Turbofan]: Eliminate the check for -0 if it's not possible/observable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/representation-change.h" 5 #include "src/compiler/representation-change.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 switch (opcode) { 621 switch (opcode) {
622 case IrOpcode::kSpeculativeNumberAdd: 622 case IrOpcode::kSpeculativeNumberAdd:
623 return simplified()->CheckedInt32Add(); 623 return simplified()->CheckedInt32Add();
624 case IrOpcode::kSpeculativeNumberSubtract: 624 case IrOpcode::kSpeculativeNumberSubtract:
625 return simplified()->CheckedInt32Sub(); 625 return simplified()->CheckedInt32Sub();
626 case IrOpcode::kSpeculativeNumberDivide: 626 case IrOpcode::kSpeculativeNumberDivide:
627 return simplified()->CheckedInt32Div(); 627 return simplified()->CheckedInt32Div();
628 case IrOpcode::kSpeculativeNumberModulus: 628 case IrOpcode::kSpeculativeNumberModulus:
629 return simplified()->CheckedInt32Mod(); 629 return simplified()->CheckedInt32Mod();
630 case IrOpcode::kSpeculativeNumberMultiply: 630 case IrOpcode::kSpeculativeNumberMultiply:
631 return simplified()->CheckedInt32Mul(); 631 // Shouldn't get here.
632 DCHECK(false);
633 return simplified()->CheckedInt32Mul(
634 CheckForMinusZeroMode::kCheckForMinusZero);
Jarin 2016/07/17 16:37:47 Just remove this case.
mvstanton 2016/07/18 08:48:58 Done.
632 default: 635 default:
633 UNREACHABLE(); 636 UNREACHABLE();
634 return nullptr; 637 return nullptr;
635 } 638 }
636 } 639 }
637 640
638 const Operator* RepresentationChanger::Uint32OperatorFor( 641 const Operator* RepresentationChanger::Uint32OperatorFor(
639 IrOpcode::Value opcode) { 642 IrOpcode::Value opcode) {
640 switch (opcode) { 643 switch (opcode) {
641 case IrOpcode::kNumberAdd: 644 case IrOpcode::kNumberAdd:
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 } 812 }
810 813
811 Node* RepresentationChanger::InsertChangeTaggedToFloat64(Node* node) { 814 Node* RepresentationChanger::InsertChangeTaggedToFloat64(Node* node) {
812 return jsgraph()->graph()->NewNode(simplified()->ChangeTaggedToFloat64(), 815 return jsgraph()->graph()->NewNode(simplified()->ChangeTaggedToFloat64(),
813 node); 816 node);
814 } 817 }
815 818
816 } // namespace compiler 819 } // namespace compiler
817 } // namespace internal 820 } // namespace internal
818 } // namespace v8 821 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698