Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2154043002: Revert of master.chromium.perf.fyi: order console by time (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
dnj, dnj (Google)
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of master.chromium.perf.fyi: order console by time (patchset #1 id:1 of https://codereview.chromium.org/2150093003/ ) Reason for revert: reverting in favor of https://codereview.chromium.org/2157703002 Original issue's description: > master.chromium.perf.fyi: order console by time > > gitiles revision comparator assumes that all rows in the changes table > were created by it, which is not the case with buildbucket, so we are > switching to a more generic comparator > > there is a possibility that it may cause some weird presentation of > console view, in particular some rows in the console view may look like > > rev deadbeef > rev badcoffee > rev deadbeef > > because changes created by buidlbucket module have timestamp equal > to the build creation time > > R=dnj@chromium.org > BUG=626019 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/5ff472dc7cd21a25d968e4a7d901000bee38304e TBR=dnj@chromium.org,dnj@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626019 Committed: https://chromium.googlesource.com/chromium/tools/build/+/725c854816b7177d0e25c4840e708f47ac6775cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M masters/master.chromium.perf.fyi/master.cfg View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nodir
Created Revert of master.chromium.perf.fyi: order console by time
4 years, 5 months ago (2016-07-16 00:57:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154043002/1
4 years, 5 months ago (2016-07-16 00:57:46 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:57:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/725c854816b7177d0e25...

Powered by Google App Engine
This is Rietveld 408576698