Chromium Code Reviews
DescriptionRevert of master.chromium.perf.fyi: order console by time (patchset #1 id:1 of https://codereview.chromium.org/2150093003/ )
Reason for revert:
reverting in favor of https://codereview.chromium.org/2157703002
Original issue's description:
> master.chromium.perf.fyi: order console by time
>
> gitiles revision comparator assumes that all rows in the changes table
> were created by it, which is not the case with buildbucket, so we are
> switching to a more generic comparator
>
> there is a possibility that it may cause some weird presentation of
> console view, in particular some rows in the console view may look like
>
> rev deadbeef
> rev badcoffee
> rev deadbeef
>
> because changes created by buidlbucket module have timestamp equal
> to the build creation time
>
> R=dnj@chromium.org
> BUG=626019
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/5ff472dc7cd21a25d968e4a7d901000bee38304e
TBR=dnj@chromium.org,dnj@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626019
Committed: https://chromium.googlesource.com/chromium/tools/build/+/725c854816b7177d0e25c4840e708f47ac6775cc
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
|||||||||||||||||||