Chromium Code Reviews| Index: chrome/browser/permissions/permission_infobar_delegate.cc |
| diff --git a/chrome/browser/permissions/permission_infobar_delegate.cc b/chrome/browser/permissions/permission_infobar_delegate.cc |
| index 88a2798932cfe0d44815d943eab0277acc240ea3..047997525a832c78c7abe738bd9b4d93f02043f9 100644 |
| --- a/chrome/browser/permissions/permission_infobar_delegate.cc |
| +++ b/chrome/browser/permissions/permission_infobar_delegate.cc |
| @@ -12,10 +12,11 @@ |
| #include "ui/base/l10n/l10n_util.h" |
| PermissionInfobarDelegate::~PermissionInfobarDelegate() { |
| - // TODO(stefanocs): Pass the actual |gesture_type| value to PermissionUmaUtil. |
| + PermissionRequestGestureType gesture_type = |
|
kcarattini
2016/07/27 03:54:53
I don't think you need the extra variable since th
stefanocs
2016/07/27 04:25:11
Done.
|
| + user_gesture_ ? PermissionRequestGestureType::GESTURE |
| + : PermissionRequestGestureType::NO_GESTURE; |
| if (!action_taken_) { |
| - PermissionUmaUtil::PermissionIgnored(permission_type_, |
| - PermissionRequestGestureType::UNKNOWN, |
| + PermissionUmaUtil::PermissionIgnored(permission_type_, gesture_type, |
| requesting_origin_, profile_); |
| } |
| } |
| @@ -24,12 +25,14 @@ PermissionInfobarDelegate::PermissionInfobarDelegate( |
| const GURL& requesting_origin, |
| content::PermissionType permission_type, |
| ContentSettingsType content_settings_type, |
| + bool user_gesture, |
| Profile* profile, |
| const base::Callback<void(bool, bool)>& callback) |
| : requesting_origin_(requesting_origin), |
| action_taken_(false), |
| permission_type_(permission_type), |
| content_settings_type_(content_settings_type), |
| + user_gesture_(user_gesture), |
| profile_(profile), |
| callback_(callback) {} |