Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3467)

Unified Diff: chrome/browser/permissions/permission_infobar_delegate.cc

Issue 2154033003: Add gesture type value from infobar to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-from-permission-layer-to-permission-report
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_infobar_delegate.cc
diff --git a/chrome/browser/permissions/permission_infobar_delegate.cc b/chrome/browser/permissions/permission_infobar_delegate.cc
index ab005677ba76247e81bc8fd0278da2c71b0372f2..1500011171e4a0096bc8cd21db8932350217ae43 100644
--- a/chrome/browser/permissions/permission_infobar_delegate.cc
+++ b/chrome/browser/permissions/permission_infobar_delegate.cc
@@ -11,10 +11,8 @@
#include "ui/base/l10n/l10n_util.h"
PermissionInfobarDelegate::~PermissionInfobarDelegate() {
- // TODO(stefanocs): Pass the actual user_gesture value to PermissionUmaUtil.
if (!action_taken_)
raymes 2016/07/19 05:25:30 nit: add {}
stefanocs 2016/07/19 07:45:27 Done.
- PermissionUmaUtil::PermissionIgnored(permission_type_,
- false /* user_gesture */,
+ PermissionUmaUtil::PermissionIgnored(permission_type_, user_gesture_,
requesting_origin_, profile_);
}
@@ -22,12 +20,14 @@ PermissionInfobarDelegate::PermissionInfobarDelegate(
const GURL& requesting_origin,
content::PermissionType permission_type,
ContentSettingsType content_settings_type,
+ bool user_gesture,
Profile* profile,
const base::Callback<void(bool, bool)>& callback)
: requesting_origin_(requesting_origin),
action_taken_(false),
permission_type_(permission_type),
content_settings_type_(content_settings_type),
+ user_gesture_(user_gesture),
profile_(profile),
callback_(callback) {}
« no previous file with comments | « chrome/browser/permissions/permission_infobar_delegate.h ('k') | chrome/browser/permissions/permission_queue_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698