Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5840)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2154033003: Add gesture type value from infobar to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-from-permission-layer-to-permission-report
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/notification_permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_context_base_unittest.cc » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index cf712d12b9edd91bf94187be7bb9e3615d4b1db6..9ff6e094fac197b2abfda4a3600a52a4095a9dad 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -191,9 +191,8 @@ void PermissionContextBase::DecidePermission(
DCHECK(inserted) << "Duplicate id " << id.ToString();
permission_request_manager->AddRequest(request);
#else
- // TODO(stefanocs): Get user gesture from infobar.
GetQueueController()->CreateInfoBarRequest(
- id, requesting_origin, embedding_origin,
+ id, requesting_origin, embedding_origin, user_gesture,
base::Bind(&PermissionContextBase::PermissionDecided,
weak_factory_.GetWeakPtr(), id, requesting_origin,
embedding_origin, user_gesture, callback,
« no previous file with comments | « chrome/browser/notifications/notification_permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_context_base_unittest.cc » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698