Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 2154033002: MD Downloads: fix focus issue on downloads page by combining pause/play (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix focus issue on downloads page by combining pause/play R=tsergeant@chromium.org BUG=605093 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true Committed: https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4 Cr-Commit-Position: refs/heads/master@{#406209}

Patch Set 1 #

Patch Set 2 : merge + re-vulcanize #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -48 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 7 chunks +28 lines, -15 lines 1 comment Download
M chrome/browser/resources/md_downloads/item.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 5 chunks +25 lines, -13 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Dan Beam
4 years, 5 months ago (2016-07-16 00:24:00 UTC) #2
Dan Beam
-groby@, +tsergeant@
4 years, 5 months ago (2016-07-19 01:40:35 UTC) #12
Dan Beam
https://codereview.chromium.org/2154033002/diff/20001/chrome/browser/resources/md_downloads/crisper.js File chrome/browser/resources/md_downloads/crisper.js (right): https://codereview.chromium.org/2154033002/diff/20001/chrome/browser/resources/md_downloads/crisper.js#newcode11418 chrome/browser/resources/md_downloads/crisper.js:11418: if (menu.items.indexOf(e.relatedTarget) >= 0) totallllly remembered to re-vulcanize after ...
4 years, 5 months ago (2016-07-19 01:41:21 UTC) #13
tsergeant
lgtm
4 years, 5 months ago (2016-07-19 03:39:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154033002/20001
4 years, 5 months ago (2016-07-19 03:59:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154033002/20001
4 years, 5 months ago (2016-07-19 04:02:40 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 04:03:36 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 04:05:30 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4
Cr-Commit-Position: refs/heads/master@{#406209}

Powered by Google App Engine
This is Rietveld 408576698