Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2153953002: Fix broken Android framework build. (Closed)

Created:
4 years, 5 months ago by djsollen
Modified:
4 years, 5 months ago
Reviewers:
msarett, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M gyp/expat.gyp View 1 chunk +16 lines, -2 lines 0 comments Download
M gyp/ports.gyp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
djsollen
4 years, 5 months ago (2016-07-15 19:26:07 UTC) #3
msarett
lgtm
4 years, 5 months ago (2016-07-15 19:28:03 UTC) #4
f(malita)
LGTM, thanks!
4 years, 5 months ago (2016-07-15 19:28:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153953002/1
4 years, 5 months ago (2016-07-15 19:31:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:52:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ec58b86437d26275ade3b1455f3272754776c44d

Powered by Google App Engine
This is Rietveld 408576698