chrome/common/extensions/api/tabs.json - Issue 2153943002: Implementing TabManager extensions API Discard Function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: secondary comments fixed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/memory/tab_manager.cc ('k') | extensions/browser/extension_function_histogram_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/tabs.json

diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json

index 637f3c0d3a385459ffd13c96c677085820b0d783..3e097bf8ad79f90f9aa205568eba9a614cb53307 100644

--- a/chrome/common/extensions/api/tabs.json

+++ b/chrome/common/extensions/api/tabs.json

@@ -907,6 +907,38 @@

]

}

]

+ },

+ {

+ "name": "discard",

+ "type": "function",

+ "description": "Discards a tab from memory. Discarded tabs are still visible on the tab strip and get reloaded when clicked on.",

Devlin 2016/07/19 22:49:12 s/clicked on/activated.

Anderson Silva 2016/07/20 16:24:01 Done.

+ "parameters": [

+ {

+ "type": "integer",

+ "name": "tabId",

+ "optional": true,

+ "minimum": 0,

+ "description": "The ID of the tab to be discarded; defaults to the least important tab."

+ },

+ {

+ "type": "function",

+ "name": "callback",

+ "optional": true,

+ "description": "Called after the operation is completed.",

+ "parameters": [

+ {

+ "name": "tab",

+ "$ref": "Tab",

+ "description": "Discarded tab if it was successfully discarded."

+ },

+ {

+ "name": "success",

+ "type": "boolean",

+ "description": "Status describing if the tab was successfully discarded or not."

Devlin 2016/07/19 22:49:12 Is there a reason for this boolean rather than usi

Anderson Silva 2016/07/20 16:24:01 The idea is that the boolean is related to the Tab

+ }

+ ]

+ }

+ ]

}

"events": [