Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reset protection time Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.h ('k') | chrome/browser/extensions/api/tabs/tabs_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index a6efc8c978387abe4d0c4c523c5009a5e2b84a3b..c43670ac9311cae7af1a10fa403731139a561a98 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -2168,4 +2168,42 @@ bool TabsGetZoomSettingsFunction::RunAsync() {
return true;
}
+ExtensionFunction::ResponseAction TabsDiscardFunction::Run() {
+ std::unique_ptr<tabs::Discard::Params> params(
+ tabs::Discard::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params);
+
+ WebContents* contents = nullptr;
+ Profile* profile = Profile::FromBrowserContext(browser_context());
+ // If |tab_id| is given, find the web_contents respective to it.
+ // Otherwise invoke discard function in TabManager with null web_contents
+ // that will discard the least important tab.
+ if (params->tab_id) {
+ int tab_id = *params->tab_id;
+ if (!GetTabById(tab_id, profile, include_incognito(), nullptr, nullptr,
+ &contents, nullptr, &error_)) {
+ return RespondNow(Error(error_));
+ }
+ }
+ // Discard the tab.
+ contents =
+ g_browser_process->GetTabManager()->DiscardTabByExtension(contents);
+
+ // Create the Tab object and return it in case of success.
+ if (contents) {
+ return RespondNow(ArgumentList(tabs::Discard::Results::Create(
+ *ExtensionTabUtil::CreateTabObject(contents))));
+ }
+
+ // Return appropriate error message otherwise.
+ return RespondNow(Error(
+ params->tab_id
+ ? ErrorUtils::FormatErrorMessage(keys::kCannotDiscardTab,
+ base::IntToString(*params->tab_id))
+ : keys::kCannotFindTabToDiscard));
+}
+
+TabsDiscardFunction::TabsDiscardFunction() {}
+TabsDiscardFunction::~TabsDiscardFunction() {}
+
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.h ('k') | chrome/browser/extensions/api/tabs/tabs_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698