chrome/browser/extensions/api/tabs/tabs_constants.cc - Issue 2153943002: Implementing TabManager extensions API Discard Function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_constants.cc

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new error messages Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_constants.h ('k') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_constants.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_constants.cc b/chrome/browser/extensions/api/tabs/tabs_constants.cc

index 2903ee9c5adf413f882ec4f5811d70903bc4cd6b..2a7f08bda9d6a9758b9e862181ef25e0da9cc8bc 100644

--- a/chrome/browser/extensions/api/tabs/tabs_constants.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_constants.cc

@@ -85,6 +85,8 @@ const char kPerOriginOnlyInAutomaticError[] = "Can only set scope to "

const char kWindowNotFoundError[] = "No window with id: *.";

const char kTabIndexNotFoundError[] = "No tab at index: *.";

const char kTabNotFoundError[] = "No tab with id: *.";

+const char kCannotDiscardTab[] = "Cannot discard tab with id: *.";

+const char kCannotFindTabToDiscard[] = "Cannot find a tab to discard.";

const char kTabStripNotEditableError[] =

"Tabs cannot be edited right now (user may be dragging a tab).";

const char kNoSelectedTabError[] = "No selected tab";