Implementing TabManager extensions API Discard Function.

chrome/browser/memory/tab_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEMORY_TAB_MANAGER_H_
 #define CHROME_BROWSER_MEMORY_TAB_MANAGER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 90 matching lines @@
   // Discards a tab to free the memory occupied by its renderer. The tab still
   // exists in the tab-strip; clicking on it will reload it.
   void DiscardTab();
 
   // Discards a tab with the given unique ID. The tab still exists in the
   // tab-strip; clicking on it will reload it. Returns null if the tab cannot
   // be found or cannot be discarded. Otherwise returns the old web_contents
   // that got discarded. This value is mostly useful during testing.
   content::WebContents* DiscardTabById(int64_t target_web_contents_id);
 
+  // If |contents| is null, discards the least important tab using DiscardTab().

[Georges Khalil, 2016/07/19 19:39:45]

Start comment by explaining that this is the function that will be called by the
extensions API.

[Anderson Silva, 2016/07/19 20:28:42]

Done.

+  // Otherwise discards the given contents.
+  content::WebContents* DiscardTabByExtension(content::WebContents* contents);
+
   // Log memory statistics for the running processes, then discards a tab.
   // Tab discard happens sometime later, as collecting the statistics touches
   // multiple threads and takes time.
   void LogMemoryAndDiscardTab();
 
   // Log memory statistics for the running processes, then call the callback.
   void LogMemory(const std::string& title, const base::Closure& callback);
 
   // Used to set the test TickClock, which then gets used by NowTicks(). See
   // |test_tick_clock_| for more details.
   void set_test_tick_clock(base::TickClock* test_tick_clock);
 
   // Returns the list of the stats for all renderers. Must be called on the UI
   // thread.
   TabStatsList GetUnsortedTabStats();
 
   // Add/remove observers.
   void AddObserver(TabManagerObserver* observer);
   void RemoveObserver(TabManagerObserver* observer);
 
+  // Used in tets to change the protection time of the tabs.

[Georges Khalil, 2016/07/19 19:39:45]

nit: tets -> tests.

+  void set_minimum_protection_time_for_tests(unsigned int time_seconds);

[Georges Khalil, 2016/07/19 19:39:45]

This should take a base::TimeDelta so there's no confusion.

[Anderson Silva, 2016/07/19 20:28:42]

Done.

+
  private:
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, CanOnlyDiscardOnce);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, ChildProcessNotifications);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, Comparator);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, DiscardedTabKeepsLastActiveTime);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, DiscardWebContentsAt);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, InvalidOrEmptyURL);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, IsInternalPage);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, OomPressureListener);
   FRIEND_TEST_ALL_PREFIXES(TabManagerTest, ProtectPDFPages);
@@ skipping 108 matching lines @@
   static bool CompareTabStats(TabStats first, TabStats second);
 
   // Returns either the system's clock or the test clock. See |test_tick_clock_|
   // for more details.
   base::TimeTicks NowTicks() const;
 
   // Dispatches a memory pressure message to a single child process, and
   // schedules another call to itself as long as memory pressure continues.
   void DoChildProcessDispatch();
 
   // Implementation of DiscardTab.

[Georges Khalil, 2016/07/19 19:39:45]

Add comment about return value.

-  bool DiscardTabImpl();
+  content::WebContents* DiscardTabImpl();
 
   // Returns true if tabs can be discarded only once.
   bool CanOnlyDiscardOnce();
 
   // Timer to periodically update the stats of the renderers.
   base::RepeatingTimer update_timer_;
 
   // Timer to periodically report whether a tab has been discarded since the
   // last time the timer has fired.
   base::RepeatingTimer recent_tab_discard_timer_;
@@ skipping 77 matching lines @@
 
   // Weak pointer factory used for posting delayed tasks to task_runner_.
   base::WeakPtrFactory<TabManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TabManager);
 };
 
 }  // namespace memory
 
 #endif  // CHROME_BROWSER_MEMORY_TAB_MANAGER_H_