Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit on function description Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> 5 #include <limits.h>
6 #include <stddef.h> 6 #include <stddef.h>
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 19 matching lines...) Expand all
30 #include "chrome/browser/profiles/profile.h" 30 #include "chrome/browser/profiles/profile.h"
31 #include "chrome/browser/ui/browser.h" 31 #include "chrome/browser/ui/browser.h"
32 #include "chrome/browser/ui/browser_commands.h" 32 #include "chrome/browser/ui/browser_commands.h"
33 #include "chrome/browser/ui/browser_window.h" 33 #include "chrome/browser/ui/browser_window.h"
34 #include "chrome/browser/ui/tabs/tab_strip_model.h" 34 #include "chrome/browser/ui/tabs/tab_strip_model.h"
35 #include "chrome/browser/ui/views/frame/browser_view.h" 35 #include "chrome/browser/ui/views/frame/browser_view.h"
36 #include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h" 36 #include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
37 #include "chrome/test/base/ui_test_utils.h" 37 #include "chrome/test/base/ui_test_utils.h"
38 #include "components/prefs/pref_service.h" 38 #include "components/prefs/pref_service.h"
39 #include "content/public/browser/browser_context.h" 39 #include "content/public/browser/browser_context.h"
40 #include "content/public/browser/notification_service.h"
40 #include "content/public/browser/storage_partition.h" 41 #include "content/public/browser/storage_partition.h"
41 #include "content/public/common/page_zoom.h" 42 #include "content/public/common/page_zoom.h"
42 #include "content/public/common/url_constants.h" 43 #include "content/public/common/url_constants.h"
43 #include "extensions/browser/api_test_utils.h" 44 #include "extensions/browser/api_test_utils.h"
44 #include "extensions/browser/app_window/app_window.h" 45 #include "extensions/browser/app_window/app_window.h"
45 #include "extensions/browser/app_window/app_window_registry.h" 46 #include "extensions/browser/app_window/app_window_registry.h"
46 #include "extensions/browser/app_window/native_app_window.h" 47 #include "extensions/browser/app_window/native_app_window.h"
47 #include "extensions/common/manifest_constants.h" 48 #include "extensions/common/manifest_constants.h"
48 #include "extensions/common/test_util.h" 49 #include "extensions/common/test_util.h"
49 #include "extensions/test/extension_test_message_listener.h" 50 #include "extensions/test/extension_test_message_listener.h"
(...skipping 1382 matching lines...) Expand 10 before | Expand all | Expand 10 after
1432 } 1433 }
1433 1434
1434 // Get discarded tabs after activating a discarded tab. 1435 // Get discarded tabs after activating a discarded tab.
1435 { 1436 {
1436 std::unique_ptr<base::ListValue> result( 1437 std::unique_ptr<base::ListValue> result(
1437 RunQueryFunction("[{\"discarded\": true}]")); 1438 RunQueryFunction("[{\"discarded\": true}]"));
1438 EXPECT_EQ(1u, result->GetSize()); 1439 EXPECT_EQ(1u, result->GetSize());
1439 } 1440 }
1440 } 1441 }
1441 1442
1443 // Tests chrome.tabs.discard(tabId).
1444 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardWithId) {
1445 // Create an aditional tab.
1446 ui_test_utils::NavigateToURLWithDisposition(
1447 browser(), GURL(url::kAboutBlankURL), NEW_BACKGROUND_TAB,
1448 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
1449 content::WebContents* web_contents =
1450 browser()->tab_strip_model()->GetWebContentsAt(1);
1451
1452 // Set up the function with an extension.
1453 scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension();
1454 scoped_refptr<TabsDiscardFunction> discard(new TabsDiscardFunction());
1455 discard->set_extension(extension.get());
1456
1457 // Run function passing the tab id as argument.
1458 int tab_id = ExtensionTabUtil::GetTabId(web_contents);
1459 std::unique_ptr<base::DictionaryValue> result(
1460 utils::ToDictionary(utils::RunFunctionAndReturnSingleResult(
1461 discard.get(), base::StringPrintf("[%u]", tab_id), browser())));
1462
1463 // Confirms that TabManager sees the tab as discarded.
1464 memory::TabManager* tab_manager = g_browser_process->GetTabManager();
1465 ASSERT_TRUE(tab_manager);
1466 web_contents = browser()->tab_strip_model()->GetWebContentsAt(1);
1467 EXPECT_TRUE(tab_manager->IsTabDiscarded(web_contents));
1468
1469 // Make sure the returned tab is the one discarded and
1470 // its discarded state is correct.
1471 tab_id = ExtensionTabUtil::GetTabId(web_contents);
1472 EXPECT_EQ(tab_id, api_test_utils::GetInteger(result.get(), "id"));
1473 EXPECT_TRUE(api_test_utils::GetBoolean(result.get(), "discarded"));
1474 }
1475
1476 // Tests chrome.tabs.discard().
1477 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardWithoutId) {
1478 // Create an aditional tab.
1479 ui_test_utils::NavigateToURLWithDisposition(
1480 browser(), GURL(url::kAboutBlankURL), NEW_BACKGROUND_TAB,
1481 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
1482 content::WebContents* web_contents =
1483 browser()->tab_strip_model()->GetWebContentsAt(1);
1484
1485 // Set up the function with an extension.
1486 scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension();
1487 scoped_refptr<TabsDiscardFunction> discard(new TabsDiscardFunction());
1488 discard->set_extension(extension.get());
1489
1490 // Disable protection time to discard the tab without passing id.
1491 memory::TabManager* tab_manager = g_browser_process->GetTabManager();
1492 ASSERT_TRUE(tab_manager);
1493 tab_manager->set_minimum_protection_time_for_tests(
1494 base::TimeDelta::FromSeconds(0));
1495
1496 // Run without passing an id.
1497 std::unique_ptr<base::DictionaryValue> result(utils::ToDictionary(
1498 utils::RunFunctionAndReturnSingleResult(discard.get(), "[]", browser())));
1499
1500 // Confirms that TabManager sees the tab as discarded.
1501 web_contents = browser()->tab_strip_model()->GetWebContentsAt(1);
1502 EXPECT_TRUE(tab_manager->IsTabDiscarded(web_contents));
1503
1504 // Make sure the returned tab is the one discarded and
1505 // its discarded state is correct.
1506 EXPECT_EQ(ExtensionTabUtil::GetTabId(web_contents),
1507 api_test_utils::GetInteger(result.get(), "id"));
1508 EXPECT_TRUE(api_test_utils::GetBoolean(result.get(), "discarded"));
1509 }
1510
1442 // Tester class for the tabs.zoom* api functions. 1511 // Tester class for the tabs.zoom* api functions.
1443 class ExtensionTabsZoomTest : public ExtensionTabsTest { 1512 class ExtensionTabsZoomTest : public ExtensionTabsTest {
1444 public: 1513 public:
1445 void SetUpOnMainThread() override; 1514 void SetUpOnMainThread() override;
1446 1515
1447 // Runs chrome.tabs.setZoom(). 1516 // Runs chrome.tabs.setZoom().
1448 bool RunSetZoom(int tab_id, double zoom_factor); 1517 bool RunSetZoom(int tab_id, double zoom_factor);
1449 1518
1450 // Runs chrome.tabs.getZoom(). 1519 // Runs chrome.tabs.getZoom().
1451 testing::AssertionResult RunGetZoom(int tab_id, double* zoom_factor); 1520 testing::AssertionResult RunGetZoom(int tab_id, double* zoom_factor);
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1865 EXPECT_TRUE( 1934 EXPECT_TRUE(
1866 base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl)); 1935 base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
1867 1936
1868 // chrome.tabs.setZoomSettings(). 1937 // chrome.tabs.setZoomSettings().
1869 error = RunSetZoomSettingsExpectError(tab_id, "manual", "per-tab"); 1938 error = RunSetZoomSettingsExpectError(tab_id, "manual", "per-tab");
1870 EXPECT_TRUE( 1939 EXPECT_TRUE(
1871 base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl)); 1940 base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
1872 } 1941 }
1873 1942
1874 } // namespace extensions 1943 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698