Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2153913002: S390: [turbofan] Introduce integer multiplication with overflow. (Closed)

Created:
4 years, 5 months ago by john.yan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [turbofan] Introduce integer multiplication with overflow. port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 R=bjaideep@ca.ibm.com, mvstanton@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/a151ea9e7c079704953ed48120068d6b432de9ed Cr-Commit-Position: refs/heads/master@{#37804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 5 months ago (2016-07-15 18:20:45 UTC) #1
JaideepBajwa
lgtm
4 years, 5 months ago (2016-07-15 18:22:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153913002/1
4 years, 5 months ago (2016-07-15 18:23:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:46:03 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:49:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a151ea9e7c079704953ed48120068d6b432de9ed
Cr-Commit-Position: refs/heads/master@{#37804}

Powered by Google App Engine
This is Rietveld 408576698