Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2153893002: [DevTools] Fix line and column in CallstackSidebarPane for async frames (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix line and column in CallstackSidebarPane for async frames Since Runtime.CallFrame is 0-based, subtraction of 1 from line and column is redundant. It was broken in: refs/heads/master@{#404923} (https://codereview.chromium.org/2145483002/). BUG=591496 R=lushnikov@chromium.org Committed: https://crrev.com/0b312cc5e879525938bd96564e933f1cd996761b Cr-Commit-Position: refs/heads/master@{#405831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kozy
Andrey, please take a look!
4 years, 5 months ago (2016-07-15 18:01:55 UTC) #1
lushnikov
lgtm let's mention a regression revision in the patch description as well
4 years, 5 months ago (2016-07-15 18:30:57 UTC) #2
kozy
On 2016/07/15 18:30:57, lushnikov wrote: > let's mention a regression revision in the patch description ...
4 years, 5 months ago (2016-07-15 18:32:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153893002/1
4 years, 5 months ago (2016-07-15 18:33:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 19:54:51 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 19:54:55 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:57:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b312cc5e879525938bd96564e933f1cd996761b
Cr-Commit-Position: refs/heads/master@{#405831}

Powered by Google App Engine
This is Rietveld 408576698