Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/browsing_data/core/counters/browsing_data_counter.h

Issue 2153863002: Move counters for passwords, history and autofill to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate_build_targets_in_components_bd
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browsing_data/core/counters/browsing_data_counter.h
diff --git a/components/browsing_data/core/counters/browsing_data_counter.h b/components/browsing_data/core/counters/browsing_data_counter.h
index 5ef123945db9a5feaff42b95aae91ab6e467dc6d..c2749364f539cabb9ae2e39b49f8650a696b11c9 100644
--- a/components/browsing_data/core/counters/browsing_data_counter.h
+++ b/components/browsing_data/core/counters/browsing_data_counter.h
@@ -58,14 +58,14 @@ class BrowsingDataCounter {
typedef base::Callback<void(std::unique_ptr<Result>)> Callback;
- BrowsingDataCounter(const std::string& pref_name);
+ BrowsingDataCounter();
virtual ~BrowsingDataCounter();
// Should be called once to initialize this class.
void Init(PrefService* pref_service, const Callback& callback);
// Name of the preference associated with this counter.
- const std::string& GetPrefName() const;
+ virtual const char* GetPrefName() const = 0;
// PrefService that manages the preferences for the user profile
// associated with this counter.
@@ -95,9 +95,6 @@ class BrowsingDataCounter {
// Count the data.
virtual void Count() = 0;
- // Name of the preference associated with this counter.
- const std::string pref_name_;
-
// Pointer to the PrefService that manages the preferences for the user
// profile associated with this counter.
PrefService* pref_service_;

Powered by Google App Engine
This is Rietveld 408576698