components/browsing_data/core/counters/browsing_data_counter.cc - Issue 2153863002: Move counters for passwords, history and autofill to components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/core/counters/browsing_data_counter.cc

Issue 2153863002: Move counters for passwords, history and autofill to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate_build_targets_in_components_bd

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/history_counter_browsertest.cc ('K') | « components/browsing_data/core/counters/browsing_data_counter.h ('k') | components/browsing_data/core/counters/history_counter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browsing_data/core/counters/browsing_data_counter.cc

diff --git a/components/browsing_data/core/counters/browsing_data_counter.cc b/components/browsing_data/core/counters/browsing_data_counter.cc

index 3aa9d51ad3f776265fa78d0cb1d82fa6e096ceab..26a374ac075283ade1220ad0a2e99b352fa5cfb9 100644

--- a/components/browsing_data/core/counters/browsing_data_counter.cc

+++ b/components/browsing_data/core/counters/browsing_data_counter.cc

@@ -13,8 +13,7 @@

namespace browsing_data {

-BrowsingDataCounter::BrowsingDataCounter(const std::string& pref_name)

- : pref_name_(pref_name) {}

+BrowsingDataCounter::BrowsingDataCounter() {}

BrowsingDataCounter::~BrowsingDataCounter() {}

@@ -61,10 +60,6 @@ void BrowsingDataCounter::ReportResult(std::unique_ptr<Result> result) {

callback_.Run(std::move(result));

}

-const std::string& BrowsingDataCounter::GetPrefName() const {

- return pref_name_;

PrefService* BrowsingDataCounter::GetPrefs() const {

return pref_service_;

}