Source/devtools/scripts/compile_frontend.py - Issue 21538002: Presubmit check for DevTools should remove the generated protocol_externs.js file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/devtools/scripts/compile_frontend.py

Issue 21538002: Presubmit check for DevTools should remove the generated protocol_externs.js file (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright (c) 2012 Google Inc. All rights reserved.	2 # Copyright (c) 2012 Google Inc. All rights reserved.

3 #	3 #

4 # Redistribution and use in source and binary forms, with or without	4 # Redistribution and use in source and binary forms, with or without

5 # modification, are permitted provided that the following conditions are	5 # modification, are permitted provided that the following conditions are

6 # met:	6 # met:

7 #	7 #

8 # * Redistributions of source code must retain the above copyright	8 # * Redistributions of source code must retain the above copyright

9 # notice, this list of conditions and the following disclaimer.	9 # notice, this list of conditions and the following disclaimer.

10 # * Redistributions in binary form must reproduce the above	10 # * Redistributions in binary form must reproduce the above

(...skipping 454 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
465 command += "\n"	465 command += "\n"

466 os.system(command)	466 os.system(command)

467 os.system("rm " + injectedScriptSourceTmpFile)	467 os.system("rm " + injectedScriptSourceTmpFile)

468 os.system("rm " + injectedScriptCanvasModuleSourceTmpFile)	468 os.system("rm " + injectedScriptCanvasModuleSourceTmpFile)

469	469

470 print "Checking generated code in InjectedScriptCanvasModuleSource.js..."	470 print "Checking generated code in InjectedScriptCanvasModuleSource.js..."

471 check_injected_webgl_calls_command = "%s/check_injected_webgl_calls_info.py %s %s/InjectedScriptCanvasModuleSource.js" % (scripts_path, webgl_rendering_cont ext_idl_path, inspector_path)	471 check_injected_webgl_calls_command = "%s/check_injected_webgl_calls_info.py %s %s/InjectedScriptCanvasModuleSource.js" % (scripts_path, webgl_rendering_cont ext_idl_path, inspector_path)

472 os.system(check_injected_webgl_calls_command)	472 os.system(check_injected_webgl_calls_command)

473	473

474 shutil.rmtree(modules_dir)	474 shutil.rmtree(modules_dir)

475 #os.system("rm " + protocol_externs_path)	475 os.system("rm " + protocol_externs_path)

OLD	NEW