Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2153783002: [fullcode] Restore context after calling ToNumber builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3279 matching lines...) Expand 10 before | Expand all | Expand 10 after
3290 __ li(scratch1, Operand(Smi::FromInt(count_value))); 3290 __ li(scratch1, Operand(Smi::FromInt(count_value)));
3291 __ AddBranchNoOvf(v0, v0, Operand(scratch1), &done); 3291 __ AddBranchNoOvf(v0, v0, Operand(scratch1), &done);
3292 // Call stub. Undo operation first. 3292 // Call stub. Undo operation first.
3293 __ Move(v0, a0); 3293 __ Move(v0, a0);
3294 __ jmp(&stub_call); 3294 __ jmp(&stub_call);
3295 __ bind(&slow); 3295 __ bind(&slow);
3296 } 3296 }
3297 3297
3298 // Convert old value into a number. 3298 // Convert old value into a number.
3299 __ Call(isolate()->builtins()->ToNumber(), RelocInfo::CODE_TARGET); 3299 __ Call(isolate()->builtins()->ToNumber(), RelocInfo::CODE_TARGET);
3300 RestoreContext();
3300 PrepareForBailoutForId(expr->ToNumberId(), BailoutState::TOS_REGISTER); 3301 PrepareForBailoutForId(expr->ToNumberId(), BailoutState::TOS_REGISTER);
3301 3302
3302 // Save result for postfix expressions. 3303 // Save result for postfix expressions.
3303 if (expr->is_postfix()) { 3304 if (expr->is_postfix()) {
3304 if (!context()->IsEffect()) { 3305 if (!context()->IsEffect()) {
3305 // Save the result on the stack. If we have a named or keyed property 3306 // Save the result on the stack. If we have a named or keyed property
3306 // we store the result under the receiver that is currently on top 3307 // we store the result under the receiver that is currently on top
3307 // of the stack. 3308 // of the stack.
3308 switch (assign_type) { 3309 switch (assign_type) {
3309 case VARIABLE: 3310 case VARIABLE:
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
3786 reinterpret_cast<uint32_t>( 3787 reinterpret_cast<uint32_t>(
3787 isolate->builtins()->OnStackReplacement()->entry())); 3788 isolate->builtins()->OnStackReplacement()->entry()));
3788 return ON_STACK_REPLACEMENT; 3789 return ON_STACK_REPLACEMENT;
3789 } 3790 }
3790 3791
3791 3792
3792 } // namespace internal 3793 } // namespace internal
3793 } // namespace v8 3794 } // namespace v8
3794 3795
3795 #endif // V8_TARGET_ARCH_MIPS 3796 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698