Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2153783002: [fullcode] Restore context after calling ToNumber builtin. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcode] Restore context after calling ToNumber builtin. BUG=chromium:628573 Committed: https://crrev.com/5d66a7f76b8e0bb1677381a5d77da276513d0993 Cr-Commit-Position: refs/heads/master@{#37796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-628573.js View 1 chunk +10 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-15 12:53:01 UTC) #2
Benedikt Meurer
Nice. Thanks, LGTM.
4 years, 5 months ago (2016-07-15 12:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153783002/1
4 years, 5 months ago (2016-07-15 12:54:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 13:17:51 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 13:17:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 13:19:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d66a7f76b8e0bb1677381a5d77da276513d0993
Cr-Commit-Position: refs/heads/master@{#37796}

Powered by Google App Engine
This is Rietveld 408576698