Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2153763005: Modify grit unit tests to test for missing resources. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify grit unit tests to test for missing resources. This is a follow up to the fix in r405892. Also cleanup some nits. BUG=628086 Committed: https://crrev.com/3994f4bcd09f300a54e70a3f75eca8661e6b5ba6 Cr-Commit-Position: refs/heads/master@{#406066}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M tools/grit/grit/format/resource_map.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/grit/grit/format/resource_map_unittest.py View 1 2 6 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Lei Zhang
4 years, 5 months ago (2016-07-16 05:11:33 UTC) #3
Dan Beam
rs lgtm
4 years, 5 months ago (2016-07-18 04:53:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153763005/40001
4 years, 5 months ago (2016-07-18 18:41:38 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 19:37:04 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:37:30 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:40:14 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3994f4bcd09f300a54e70a3f75eca8661e6b5ba6
Cr-Commit-Position: refs/heads/master@{#406066}

Powered by Google App Engine
This is Rietveld 408576698