runtime/vm/gc_sweeper.cc - Issue 2153763004: Both the mutator and the background compiler may be waiting on the sweeper task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_sweeper.cc

Issue 2153763004: Both the mutator and the background compiler may be waiting on the sweeper task. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/gc_sweeper.cc

diff --git a/runtime/vm/gc_sweeper.cc b/runtime/vm/gc_sweeper.cc

index 5b7949b50d41b32808ffdf2daaddf1e4a4856aac..e37f1db0c29f0e0f2104a81c72eb3a5a981f6578 100644

--- a/runtime/vm/gc_sweeper.cc

+++ b/runtime/vm/gc_sweeper.cc

@@ -152,7 +152,7 @@ class SweeperTask : public ThreadPool::Task {

{

MonitorLocker ml(old_space_->tasks_lock());

old_space_->set_tasks(old_space_->tasks() - 1);

- ml.Notify();

+ ml.NotifyAll();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »