Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2153763002: Add user gesture field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-ui-to-permission-report
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index 978d309f47f66d292265c5e25f101528061e86fe..808818f5d4e54324ab2f89e6cd22c1a7e3d1a79c 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -284,12 +284,13 @@ void SafeBrowsingUIManager::ReportPermissionAction(
const GURL& origin,
content::PermissionType permission,
PermissionAction action,
- PermissionSourceUI source_ui) {
+ PermissionSourceUI source_ui,
+ bool user_gesture) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&SafeBrowsingUIManager::ReportPermissionActionOnIOThread, this,
- origin, permission, action, source_ui));
+ origin, permission, action, source_ui, user_gesture));
}
void SafeBrowsingUIManager::AddObserver(Observer* observer) {
@@ -318,7 +319,8 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
const GURL& origin,
content::PermissionType permission,
PermissionAction action,
- PermissionSourceUI source_ui) {
+ PermissionSourceUI source_ui,
+ bool user_gesture) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// The service may delete the ping manager (i.e. when user disabling service,
@@ -326,8 +328,8 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
if (!sb_service_ || !sb_service_->ping_manager())
return;
- sb_service_->ping_manager()->ReportPermissionAction(origin, permission,
- action, source_ui);
+ sb_service_->ping_manager()->ReportPermissionAction(
+ origin, permission, action, source_ui, user_gesture);
}
// If the user had opted-in to send ThreatDetails, this gets called
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698