chrome/browser/safe_browsing/ping_manager.cc - Issue 2153763002: Add user gesture field to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 2153763002: Add user gesture field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-ui-to-permission-report

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/ping_manager.cc

diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc

index 4f0abbf45484042d83fa8f8869165a37d3e093ac..2b592b270c16adb492e91dd63484f86339ba30ef 100644

--- a/chrome/browser/safe_browsing/ping_manager.cc

+++ b/chrome/browser/safe_browsing/ping_manager.cc

@@ -139,8 +139,10 @@ void SafeBrowsingPingManager::ReportPermissionAction(

const GURL& origin,

content::PermissionType permission,

PermissionAction action,

- PermissionSourceUI source_ui) {

- permission_reporter_->SendReport(origin, permission, action, source_ui);

+ PermissionSourceUI source_ui,

+ bool user_gesture) {

+ permission_reporter_->SendReport(origin, permission, action, source_ui,

+ user_gesture);

}

GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(

« no previous file with comments | « chrome/browser/safe_browsing/ping_manager.h ('k') | chrome/browser/safe_browsing/ui_manager.h » ('j') | no next file with comments »