Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2153763002: Add user gesture field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-ui-to-permission-report
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter.cc b/chrome/browser/safe_browsing/permission_reporter.cc
index 359deb50122f3ff6a6e15eb222cd0752747777f1..31ee67908b0368c13f73cbbb3faa0431568f5973 100644
--- a/chrome/browser/safe_browsing/permission_reporter.cc
+++ b/chrome/browser/safe_browsing/permission_reporter.cc
@@ -131,11 +131,13 @@ PermissionReporter::~PermissionReporter() {}
void PermissionReporter::SendReport(const GURL& origin,
content::PermissionType permission,
PermissionAction action,
- PermissionSourceUI source_ui) {
+ PermissionSourceUI source_ui,
+ bool user_gesture) {
if (IsReportThresholdExceeded(permission, origin))
return;
std::string serialized_report;
- BuildReport(origin, permission, action, source_ui, &serialized_report);
+ BuildReport(origin, permission, action, source_ui, user_gesture,
+ &serialized_report);
permission_report_sender_->Send(GURL(kPermissionActionReportingUploadUrl),
serialized_report);
}
@@ -145,12 +147,15 @@ bool PermissionReporter::BuildReport(const GURL& origin,
PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
+ bool user_gesture,
std::string* output) {
PermissionReport report;
report.set_origin(origin.spec());
report.set_permission(PermissionTypeForReport(permission));
report.set_action(PermissionActionForReport(action));
report.set_source_ui(SourceUIForReport(source_ui));
+ if (user_gesture)
+ report.add_request_trigger(PermissionReport::AFTER_GESTURE);
// Collect platform data.
#if defined(OS_ANDROID)
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.h ('k') | chrome/browser/safe_browsing/permission_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698