Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2153763002: Add user gesture field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-ui-to-permission-report
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/permission_reporter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index a2c1c7948ad52f704d364c8d1360f9f0b71272ba..d25bc5befe38b005782c97b6a64d3cc1342fb95e 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -342,10 +342,11 @@ void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
if (IsOptedIntoPermissionActionReporting(profile)) {
// TODO(stefanocs): Add browsertests to make sure the reports are being
// sent.
+ // TODO(stefanocs): Get the actual |user_gesture| from permission layer.
g_browser_process->safe_browsing_service()
->ui_manager()
->ReportPermissionAction(requesting_origin, permission, action,
- source_ui);
+ source_ui, false /* user_gesture */);
}
bool secure_origin = content::IsOriginSecure(requesting_origin);
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/permission_reporter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698