[gn] Set correct defaults for some gn args

[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064
Committed: https://crrev.com/911ff2672e68285f39887cee18fece46145d87c9
Cr-Commit-Position: refs/heads/master@{#37797}

[Michael Achenbach, 2016-07-15 10:45:50]

Description was changed from

==========
[gn] Set correct defaults for some gn args

BUG=
==========

to

==========
[gn] Set correct defaults for some gn args

BUG=chromium:474921
==========

[Michael Achenbach, 2016-07-15 10:45:55]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 10:45:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 11:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 11:11:14]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-15 11:29:35]

Description was changed from

==========
[gn] Set correct defaults for some gn args

BUG=chromium:474921
==========

to

==========
[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064
==========

[Michael Achenbach, 2016-07-15 11:29:35]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-07-15 11:33:17]

PTAL

https://codereview.chromium.org/2153753002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2153753002/diff/1/BUILD.gn#newcode75
BUILD.gn:75: if (defined(v8_imminent_deprecation_warnings_default)) {
Without guarding with the defined check, we'd need to provide upstream changes
to chromium and pdfium first, which I find more brittle.

[jochen (gone - plz use gerrit), 2016-07-15 14:37:47]

lgtm

[Michael Achenbach, 2016-07-15 14:38:35]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-15 14:38:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 14:41:00]

Description was changed from

==========
[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064
==========

to

==========
[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064
==========

[commit-bot: I haz the power, 2016-07-15 14:41:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 14:43:05]

Description was changed from

==========
[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064
==========

to

==========
[gn] Set correct defaults for some gn args

This sets default values for v8_enable_gdbjit and
v8_imminent_deprecation_warnings, while allowing to override
them as gn args.

Without this patch the project-specific overrides have no
effect.

BUG=chromium:474921, chromium:626064

Committed: https://crrev.com/911ff2672e68285f39887cee18fece46145d87c9
Cr-Commit-Position: refs/heads/master@{#37797}
==========

[commit-bot: I haz the power, 2016-07-15 14:43:05]

Patchset 1 (id:??) landed as
https://crrev.com/911ff2672e68285f39887cee18fece46145d87c9
Cr-Commit-Position: refs/heads/master@{#37797}