Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2153703002: Start translating Material Design Settings again (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start translating Material Design Settings again R=thestig@chromium.org BUG=627474 Committed: https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd Cr-Commit-Position: refs/heads/master@{#405884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -39 lines) Patch
M chrome/app/settings_chromium_strings.grd View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/app/settings_google_chrome_strings.grd View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/app/settings_strings.grd View 1 chunk +1 line, -12 lines 0 comments Download
M tools/gritsettings/translation_expectations.pyl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dan Beam
4 years, 5 months ago (2016-07-15 22:06:06 UTC) #1
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-15 22:17:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153703002/1
4 years, 5 months ago (2016-07-15 22:23:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:38:45 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 22:38:56 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:41:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd
Cr-Commit-Position: refs/heads/master@{#405884}

Powered by Google App Engine
This is Rietveld 408576698